Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flag another curl error as possibly spurious #9695

Merged
merged 1 commit into from
Jul 16, 2021
Merged

Flag another curl error as possibly spurious #9695

merged 1 commit into from
Jul 16, 2021

Conversation

alexcrichton
Copy link
Member

@rust-highfive
Copy link

r? @Eh2406

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 15, 2021
@ehuss
Copy link
Contributor

ehuss commented Jul 15, 2021

Do you have any sense why this would start occurring? Is it certain this is related to the update to curl-sys?

@alexcrichton
Copy link
Member Author

No idea myself unfortunately, although it does seems highly related. Not that I know why :(

@alexcrichton alexcrichton mentioned this pull request Jul 15, 2021
Closed
@alexcrichton
Copy link
Member Author

Ok I debugged some more, and I think we still want to land this to help mitigate the impact on nightly in the short-term ideally.

@ehuss
Copy link
Contributor

ehuss commented Jul 16, 2021

Ok, sounds good. I haven't tested this myself, but I'll assume it will help. I'll try to push it out to nightly quickly.

@bors r+

@bors
Copy link
Contributor

bors commented Jul 16, 2021

📌 Commit 5d7a2b8 has been approved by ehuss

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 16, 2021
@bors
Copy link
Contributor

bors commented Jul 16, 2021

⌛ Testing commit 5d7a2b8 with merge 27277d9...

@bors
Copy link
Contributor

bors commented Jul 16, 2021

☀️ Test successful - checks-actions
Approved by: ehuss
Pushing 27277d9 to master...

@bors bors merged commit 27277d9 into rust-lang:master Jul 16, 2021
@ehuss ehuss mentioned this pull request Jul 16, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 16, 2021
@bors
Auto merge of rust-lang#87177 - ehuss:update-cargo, r=ehuss
057050a 
Update cargo

6 commits in 66a6737a0c9f3a974af2dd032a65d3e409c77aac..27277d966b3cfa454d6dea7f724cb961c036251c
2021-07-14 20:54:28 +0000 to 2021-07-16 00:50:39 +0000
- Flag another curl error as possibly spurious (rust-lang/cargo#9695)
- Add `d` as an alias for `doc` (rust-lang/cargo#9680)
- `cargo fix --edition`: extend warning when on latest edition (rust-lang/cargo#9694)
- Update env_logger requirement from 0.8.1 to 0.9.0 (rust-lang/cargo#9688)
- Document cargo limitation w/ workspaces & configs (rust-lang/cargo#9674)
- Change some warnings to errors (rust-lang/cargo#9689)
@ehuss ehuss mentioned this pull request Jul 16, 2021
Open
@vakaras vakaras mentioned this pull request Jul 17, 2021
Merged
@Logarithmus Logarithmus mentioned this pull request Jul 27, 2021
Closed
2 tasks
@Logarithmus
Copy link

@ehuss @alexcrichton will this fix be included in rust 1.54? Or we'll have to wait for another 6 weeks for 1.55?

@ehuss
Copy link
Contributor

ehuss commented Jul 27, 2021

It shouldn't be necessary for 1.54, as the regression (rust-lang/rust#86874) was introduced in 1.55. Are you seeing problems with 1.54?

@Logarithmus
Copy link

Logarithmus commented Aug 1, 2021 •
edited
Loading

It shouldn't be necessary for 1.54, as the regression (rust-lang/rust#86874) was introduced in 1.55. Are you seeing problems with 1.54?

We at Void Linux see this issue in cargo 0.54.0 (rust 1.53). Will updating to 1.54.0 help?
https://github.com/void-linux/void-packages/pull/29756/checks?check_run_id=3167301912#step:8:256

error: failed to download from `https://crates.io/api/v1/crates/arrayref/0.3.6/download`

Caused by:
  [55] Failed sending data to the peer (Connection died, tried 5 times before giving up)

@ehuss
Copy link
Contributor

ehuss commented Aug 1, 2021

Are you using a custom build of Cargo using a different version of libcurl? If so, what is the exact version?

@Logarithmus
Copy link

Logarithmus commented Aug 1, 2021 via email

@ehuss
Copy link
Contributor

ehuss commented Aug 1, 2021

Ah. I believe you will need to revert to curl 7.76, or wait for Rust 1.55.

@Logarithmus
Copy link

Logarithmus commented Aug 1, 2021 •
edited
Loading

Ah. I believe you will need to revert to curl 7.76, or wait for Rust 1.55.

Most likely we won't revert our curl because of possible CVE fixes between those 2 releases. Maybe we will patch out the part which causes issues.

@iMichka iMichka mentioned this pull request Aug 25, 2021
Closed
6 tasks
iMichka added a commit to iMichka/homebrew-core that referenced this pull request Aug 27, 2021
@iMichka
rust: workaround flaky crates.io downloads
24f42e5 
See
rust-lang/cargo#9695
BrewTestBot pushed a commit to Homebrew/homebrew-core that referenced this pull request Aug 27, 2021
@iMichka @BrewTestBot
rust: workaround flaky crates.io downloads
99fc0b8 
See
rust-lang/cargo#9695

Closes #83977.

Signed-off-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com>
Signed-off-by: BrewTestBot <1589480+BrewTestBot@users.noreply.github.com>
@connec connec mentioned this pull request Sep 10, 2021
Merged
connec pushed a commit to maidsafe/temp_safe_network that referenced this pull request Sep 10, 2021
@connec
ci: Pin specific nightly for cargo udeps job
faa6127 
This is a slightly speculative fix based on
https://gh.neting.ccmunity/t/189130 and
rust-lang/cargo#9695. Although it seems this may
have been fixed/worked around in cargo, the latest version of
`cargo-udeps` still depends on cargo 0.54.0 which could be affected.
@ehuss ehuss added this to the 1.55.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Eh2406 Eh2406

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.55.0
Development

Successfully merging this pull request may close these issues.
6 participants
@alexcrichton @rust-highfive @ehuss @bors @Logarithmus @Eh2406