Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show "Mailchimp" customer tab when the extension is enabled #201

Merged
merged 1 commit into from
Feb 9, 2018
Merged

Show "Mailchimp" customer tab when the extension is enabled #201

merged 1 commit into from
Feb 9, 2018

Conversation

t-richards
Copy link
Contributor

@t-richards t-richards commented Feb 8, 2018

This PR fixes the page layout for Customer > Index > Edit so that the "Mailchimp" tab is only displayed when the extension is enabled.

As a side effect, attempting to load the customer's interests no longer happens, which should fix #200 .

@gonzaloebiz gonzaloebiz self-assigned this Feb 9, 2018
@gonzaloebiz gonzaloebiz added this to the 1.0.28 milestone Feb 9, 2018
@gonzaloebiz
Copy link
Collaborator

gonzaloebiz commented Feb 9, 2018

Hi @t-richards

first of all, thanks for your feedback.
The main idea is OK, the tab must be displayed only when the extension is enabled and your PR fix it.
But i must say that i can't replicate the issue #200
So, you can please change the subject of the PR, that way we maintain documented your PR

Best

@t-richards t-richards changed the title Allow editing customers without API key Show "Mailchimp" customer tab when the extension is enabled Feb 9, 2018
@t-richards
Copy link
Contributor Author

The PR title has been changed.

@gonzaloebiz gonzaloebiz added the bug label Feb 9, 2018
@gonzaloebiz gonzaloebiz merged commit a057a8d into mailchimp:develop Feb 9, 2018
@t-richards t-richards deleted the bugfix/customer-edit branch February 9, 2018 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to edit customer without API key
2 participants