Disable forced test selector stripping in addon templates #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
reviewed
May 26, 2017
| let host = this._findHost(); | ||
| this._assignOptions(host); | ||
|
|
||
| // we can't use the setupPreprocessorRegistry() hook as it is called to |
There was a problem hiding this comment.
FWIW, this will be fixed in ember-cli/ember-cli#7059.
There was a problem hiding this comment.
ohhh... so that's what that PR is for 😄
Merged
2 tasks
rwjblue
reviewed
May 26, 2017
| if (this._stripTestSelectors) { | ||
| let StripTestSelectorsTransform = require('./strip-test-selectors'); | ||
|
|
||
| registry.add('htmlbars-ast-plugin', { |
There was a problem hiding this comment.
Seems like this could be made a bit simpler/easy to read:
let transform = 'transform-test-selector-params-to-hash-pairs';
if (this._stripTestSelectors) {
transform = 'strip-test-selectors';
}
registry.add('htmlbars-ast-plugin', {
name: transform,
plugin: require(`./${transform}`),
baseDir() { return __dirname; }
});There was a problem hiding this comment.
sure, seems like an unrelated refactoring though :)
marcoow
approved these changes
May 30, 2017
|
Thanks @Turbo87!!! 💯 |
Turbo87
pushed a commit
that referenced
this pull request
Oct 15, 2018
… to 1.0.5 (#257) Bumps [ember-cli-htmlbars-inline-precompile](https://github.com/ember-cli/ember-cli-htmlbars-inline-precompile) from 1.0.4 to 1.0.5. <details> <summary>Changelog</summary> *Sourced from [ember-cli-htmlbars-inline-precompile's changelog](https://github.com/ember-cli/ember-cli-htmlbars-inline-precompile/blob/master/CHANGELOG.md).* > ## v1.0.5 (2018-10-12) > > #### 🚀 Enhancement > * [#115](https://github-redirect.dependabot.com/ember-cli/ember-cli-htmlbars-inline-precompile/pull/115) Update `ember-cli-babel` peer dependency to support Babel 7 too. ([[**Turbo87**](https://github.com/Turbo87)](https://github.com/Turbo87)) > > #### Committers: 1 > - Tobias Bieniek ([Turbo87](https://github.com/Turbo87)) </details> <details> <summary>Commits</summary> - [`f8f9976`](ember-cli/ember-cli-htmlbars-inline-precompile@f8f9976) v1.0.5 - [`df072d7`](ember-cli/ember-cli-htmlbars-inline-precompile@df072d7) Merge pull request [#117](https://github-redirect.dependabot.com/ember-cli/ember-cli-htmlbars-inline-precompile/issues/117) from Turbo87/changelog - [`7aee0c9`](ember-cli/ember-cli-htmlbars-inline-precompile@7aee0c9) Use `lerna-changelog` to generate `CHANGELOG.md` - [`27dbeaa`](ember-cli/ember-cli-htmlbars-inline-precompile@27dbeaa) Merge pull request [#115](https://github-redirect.dependabot.com/ember-cli/ember-cli-htmlbars-inline-precompile/issues/115) from Turbo87/babel-7 - [`45878e3`](ember-cli/ember-cli-htmlbars-inline-precompile@45878e3) Update `ember-cli-babel` peer dependency to support Babel 7 too - [`cede1a4`](ember-cli/ember-cli-htmlbars-inline-precompile@cede1a4) Merge pull request [#116](https://github-redirect.dependabot.com/ember-cli/ember-cli-htmlbars-inline-precompile/issues/116) from Turbo87/insane - [`53fc443`](ember-cli/ember-cli-htmlbars-inline-precompile@53fc443) Update `yarn.lock` file - [`a610a52`](ember-cli/ember-cli-htmlbars-inline-precompile@a610a52) Update `ember-cli` to v2.12.x to drop broken `npm` subdependency - [`85a2aac`](ember-cli/ember-cli-htmlbars-inline-precompile@85a2aac) Pin subdependencies to versions using sane@2 - See full diff in [compare view](ember-cli/ember-cli-htmlbars-inline-precompile@v1.0.4...v1.0.5) </details> <br /> [](https://dependabot.com/compatibility-score.html?dependency-name=ember-cli-htmlbars-inline-precompile&package-manager=npm_and_yarn&previous-version=1.0.4&new-version=1.0.5) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Automerge options (never/patch/minor, and dev/runtime dependencies) - Pull request limits (per update run and/or open at any time) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) Finally, you can contact us by mentioning @dependabot. </details>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #95
/cc @lukemelia @rwjblue