Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert to V2 Addon #2028

Merged
merged 5 commits into from
Oct 6, 2023
Merged

Convert to V2 Addon #2028

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5e42118
npx ember-addon-migrator extract-tests --addon-location qunit-dom --i…
NullVoxPopuli Sep 23, 2023
388e29d
V2 Conversion
NullVoxPopuli Sep 23, 2023
405d77e
Remove note matrix test
NullVoxPopuli Oct 6, 2023
5ce0f55
Ensure modern dev deps
NullVoxPopuli Oct 6, 2023
11b216e
Use real type=module, ESM, publint, and arethetypeswrong
NullVoxPopuli Oct 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ on:
- cron: '0 3 * * *' # daily, at 3am

env:
PNPM_VERSION: 7.33.6
PNPM_VERSION: 8.8.0

jobs:
docs:
Expand All @@ -25,7 +25,7 @@ jobs:

- uses: actions/setup-node@v3.8.1
with:
node-version: 16
node-version: 18.17
cache: pnpm

- run: pnpm install
Expand All @@ -35,11 +35,7 @@ jobs:
- run: git diff --exit-code

test:
strategy:
matrix:
node: ['14', '16', '18.17']

name: Tests (Node.js v${{ matrix.node }})
name: Tests
runs-on: ubuntu-latest

steps:
Expand All @@ -50,7 +46,7 @@ jobs:

- uses: actions/setup-node@v3.8.1
with:
node-version: ${{ matrix.node }}
node-version: 18.17
cache: pnpm

- run: pnpm install
Expand Down Expand Up @@ -78,7 +74,7 @@ jobs:

- uses: actions/setup-node@v3.8.1
with:
node-version: 16
node-version: 18.17
cache: pnpm

- run: pnpm install
Expand Down
6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,12 @@
"prettier": "^2.8.8"
},
"engines": {
"node": ">= 16.*",
"node": ">= 18.*",
BobrImperator marked this conversation as resolved.
Show resolved Hide resolved
"yarn": "use pnpm",
"npm": "use pnpm"
},
"volta": {
"node": "16.20.2",
"pnpm": "7.33.0"
"node": "18.17.1",
"pnpm": "8.8.0"
}
}
Loading
Loading