Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bringup launch file and URDF to support real Mini Pupper #45

Merged
merged 7 commits into from
Mar 4, 2023

Conversation

Tiryoh
Copy link
Contributor

@Tiryoh Tiryoh commented Feb 13, 2023

Proposed change(s)

support real Mini Pupper

Useful links (GitHub issues, forum threads, etc.)

Provide any relevant links here.

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code refactor (non-breaking change which refactor the code)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update only
  • Other (please describe)

Testing and Verification

Please describe the tests that you ran to verify your changes. Please also provide instructions and ROS packages as appropriate so we can reproduce the test environment.

  1. ssh login to Mini Pupper
  2. checkout https://github.com/Tiryoh/mangdang_mini_pupper_ros/tree/patch-15 and run colcon build --symlink-install
  3. ros2 launch mini_pupper_bringup bringup.launch.py
  4. ros2 run teleop_twist_keyboard teleop_twist_keyboard

Test Configuration

Mini Pupper Version
Mini Pupper

Raspberry Pi OS + ROS version
Ubuntu 22.04, ROS 2 Humble

PC OS + ROS version
Ubuntu 22.04, ROS 2 Humble

Checklist

  • I have read the CONTRIBUTING guidelines.
  • I have checked to ensure there aren't other open Pull Requests for the same change.

Other comments

@@ -150,3 +164,19 @@ limitations under the License.
* A. No. Ubuntu 22.04 only for now.
* Q. Is ROS 2 Foxy/Galactic supported?
* A. No. ROS 2 Humble only for now.
* Q. `colcon build` shows `1 package had stderr output: mini_pupper_control`.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it should be fixed by downgrading setuptools: pip3 install setuptools==58.2.0

Copy link
Contributor Author

@Tiryoh Tiryoh Feb 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the detailed information!
I would just like to point out that this error (warning) is an issue with the build tool and not with this ROS package.

Copy link
Contributor Author

@Tiryoh Tiryoh Feb 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tiryoh Tiryoh added the enhancement New feature or request label Feb 19, 2023
@Tiryoh Tiryoh force-pushed the patch-15 branch 2 times, most recently from 9eca06e to 7db67d6 Compare March 4, 2023 08:14
Co-authored-by: 0nhc <thefoxfoxfox@outlook.com>
@Tiryoh Tiryoh marked this pull request as ready for review March 4, 2023 09:56
@Tiryoh Tiryoh changed the title Update bringup launch file to support real Mini Pupper Update bringup launch file and URDF to support real Mini Pupper Mar 4, 2023
@Tiryoh Tiryoh merged commit ab4bad7 into mangdangroboticsclub:ros2 Mar 4, 2023
@Tiryoh Tiryoh mentioned this pull request Mar 26, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants