Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gazebo lidar scan frame_name #52

Merged

Conversation

Tiryoh
Copy link
Contributor

@Tiryoh Tiryoh commented Mar 7, 2023

Proposed change(s)

This pull request changes the frame_name of the scan topic to lidar_link.
This change is to match the configuration when using LD06.

https://github.com/mangdangroboticsclub/mini_pupper_ros/pull/45/files#diff-05da6729185417799ca0b81bf54d30ca675a1c6cb7e97600b963c19086c75d02

Useful links (GitHub issues, forum threads, etc.)

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code refactor (non-breaking change which refactor the code)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update only
  • Other (please describe)

Testing and Verification

  1. ros2 launch mini_pupper_gazebo gazebo.launch.py
  2. ros2 launch mini_pupper_navigation bringup.launch.py use_sim_time:=true
  3. See the console log on the second terminal

Test Configuration

Mini Pupper Version
Simulator

PC OS + ROS version
Ubuntu 22.04, ROS 2 Humble

Checklist

  • I have read the CONTRIBUTING guidelines.
  • I have checked to ensure there aren't other open Pull Requests for the same change.

Other comments

I don't know why but this helps to fix the following message

[rviz2-4] [INFO] [1678205135.199224077] [rviz2]: Message Filter dropping message: frame 'lidar' at time 1678205129.143 for reason 'discarding message because the queue is full'

@Tiryoh Tiryoh added this to the ROS 2 Humble Patch Release 1 milestone Mar 7, 2023
@Tiryoh Tiryoh merged commit 946229b into mangdangroboticsclub:ros2 Mar 8, 2023
@Tiryoh Tiryoh mentioned this pull request Mar 26, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant