Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bold inline or inline-block text inside another inline/inline-block element offsets line height #775

Closed
samanpwbb opened this issue May 8, 2017 · 2 comments
Closed

bold inline or inline-block text inside another inline/inline-block element offsets line height #775

samanpwbb opened this issue May 8, 2017 · 2 comments
Assignees
@samanpwbb
Labels
bug
Milestone
1.0

Comments

@samanpwbb
Copy link
Contributor

This is a sad off-by-one situation that I would love to avoid:

screen shot 2017-05-08 at 1 42 45 pm
screen shot 2017-05-08 at 1 42 52 pm
@samanpwbb samanpwbb added the bug label May 8, 2017
@davidtheclark
Copy link
Contributor

I noticed that and wished it was an optical illusion.

@samanpwbb samanpwbb changed the title bold inline or inline-block text inside offsets line height bold inline or inline-block text inside another inline/inline-block element offsets line height May 8, 2017
@samanpwbb samanpwbb added this to the 1.0 milestone May 19, 2017
@samanpwbb samanpwbb assigned samanpwbb and unassigned samanpwbb May 19, 2017
samanpwbb added a commit that referenced this issue May 25, 2017
@samanpwbb
force txt-bold to be 1em line height, fixes line height offsets, closes
60f2f0b 
#775
@samanpwbb samanpwbb mentioned this issue May 25, 2017
Merged
@davidtheclark
Copy link
Contributor

Reopening this following discussion at #784 (comment)

A couple of notes about this issue:

@davidtheclark davidtheclark reopened this May 30, 2017
davidtheclark pushed a commit that referenced this issue May 30, 2017
New copy of Open Sans
c2ea055 
Reverts prior line-height change to bold weight.

Closes #775.
@davidtheclark davidtheclark mentioned this issue May 30, 2017
Merged
davidtheclark pushed a commit that referenced this issue May 30, 2017
New copy of Open Sans
f4fb119 
Reverts prior line-height change to bold weight.

Closes #775.
samanpwbb pushed a commit that referenced this issue May 30, 2017
@davidtheclark @samanpwbb
New copy of Open Sans (#786)
b2abfbb 
Reverts prior line-height change to bold weight.

Closes #775.
davidtheclark pushed a commit that referenced this issue Jul 2, 2017
@samanpwbb
force txt-bold to be 1em line height, fixes line height offsets, closes
b0a26f1 
#775
davidtheclark added a commit that referenced this issue Jul 2, 2017
@davidtheclark
New copy of Open Sans (#786)
aa643c3 
Reverts prior line-height change to bold weight.

Closes #775.
samanpwbb added a commit that referenced this issue Jul 5, 2017
@samanpwbb
v0.14.0 (#814)
9b2d5e5 
* adjust icon sizing, add icon-wrapper class, closes #763

* rename icon-wrapper to icon-inliner, other small fixes

* force txt-bold to be 1em line height, fixes line height offsets, closes #775

* rework size scale, closes #749

* Add limiter class, consistify scale even more

* only single-declaration utility classes should have important (#785)

* New copy of Open Sans (#786)

Reverts prior line-height change to bold weight.

Closes #775.

* reset abbr text-decoration, fixes txt-abbr rule (#788)

* Weight loss program (#787)

See changes in changelog.md

* Lighten gray-faint and add a line of caution to color documentation

* Reintroduce darken5 and lighten5 for backgrounds only

* Add icons option to build script (#794)

options.icons is an array of icon names. If this option is used, only icon names that match options.icons will be included in Assembly. Closes #782

* adds color and hover state to prose links (#798)

* Make uglify-js a real dependency

Closes #800.

* add unprose class, closes #793 (#795)

* add select--xs class to match btn--xs (#811)

* fix spin animation utility (#812)

closes #790

* prepare v0.14.0 (#813)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samanpwbb samanpwbb

Labels
bug
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
2 participants
@samanpwbb @davidtheclark