Add icons option to build script #794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samanpwbb
force-pushed
the
control-svgs
branch
3 times, most recently
from
6e4e2fd
to
9b772bf
Compare
options.icons is an array of icon names. If this option is used, only icon names that match options.icons will be included in Assembly. Closes #782
samanpwbb
changed the title
davidtheclark
approved these changes
Jun 12, 2017
| return expect(buildJs({ | ||
| outfile: tmp, | ||
| icons: ['airplane', 'pizza'] | ||
| })).rejects.toEqual(Error('an icon matching pizza does not exist')); |
There was a problem hiding this comment.
I did not know about this rejects thing!
There was a problem hiding this comment.
Ya, I didn't either. Had trouble testing a rejecting promise case, so ended up looking into it a little and came across this. It's new as of Jest 0.20.0.
davidtheclark
pushed a commit
that referenced
this pull request
Jul 2, 2017
options.icons is an array of icon names. If this option is used, only icon names that match options.icons will be included in Assembly. Closes #782
samanpwbb
added a commit
that referenced
this pull request
Jul 5, 2017
* adjust icon sizing, add icon-wrapper class, closes #763 * rename icon-wrapper to icon-inliner, other small fixes * force txt-bold to be 1em line height, fixes line height offsets, closes #775 * rework size scale, closes #749 * Add limiter class, consistify scale even more * only single-declaration utility classes should have important (#785) * New copy of Open Sans (#786) Reverts prior line-height change to bold weight. Closes #775. * reset abbr text-decoration, fixes txt-abbr rule (#788) * Weight loss program (#787) See changes in changelog.md * Lighten gray-faint and add a line of caution to color documentation * Reintroduce darken5 and lighten5 for backgrounds only * Add icons option to build script (#794) options.icons is an array of icon names. If this option is used, only icon names that match options.icons will be included in Assembly. Closes #782 * adds color and hover state to prose links (#798) * Make uglify-js a real dependency Closes #800. * add unprose class, closes #793 (#795) * add select--xs class to match btn--xs (#811) * fix spin animation utility (#812) closes #790 * prepare v0.14.0 (#813)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
options.icons is an array of icon names. If this option is used, only icon names that match options.icons will be included in Assembly. Closes #782
In order to properly test changes, I had to upgrade Jest (jestjs/jest#3068).
@davidtheclark for review.