Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Must not abort if exception thrown in threadpool #123

Closed
springmeyer opened this issue Nov 22, 2016 · 1 comment
Closed

Must not abort if exception thrown in threadpool #123

springmeyer opened this issue Nov 22, 2016 · 1 comment

Comments

@springmeyer
Copy link
Contributor

There are many functions being used in the threadpool that might throw. Whenever this is the case there MUST be a try/catch around the async code. Otherwise a C++ exception will go unhandled and lead to an abort (aka terminate) which will stop the entire node process similar to a crash. This should never happen and bugs like this need to be avoided. Another case of this try/catch going missing is mapbox/carmen-cache#56.

I'm creating this issue because I just hit a case where glyphs.SerializeAsString() threw and caused an abort inside RangeAsync.

@springmeyer springmeyer changed the title Will abort if exception throw in threadpool Must not abort if exception thrown in threadpool Nov 22, 2016
springmeyer pushed a commit that referenced this issue Nov 23, 2016
@springmeyer
Copy link
Contributor Author

Handled by #128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant