This repository has been archived by the owner on Nov 21, 2024. It is now read-only.
Eval-less filter implementation #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Gut feeling was wrong, real-world benchmark shows it's 5 times slower. :( 205ms to filter 100 dense z11 tiles vs 43ms on master. However this may be acceptable compared to other processing times on the worker side. In addition, it creates filters 10 times faster (7.6ms vs 78ms in the bench). |
mourner
changed the title
|
Not viable for now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6, #8, #10.
Needs a real world benchmark (working on it), but gut feeling it’s comparable in general case and faster in case of
infilters.cc @jfirebaugh @ansis @lucaswoj @dcervelli @tmcw