New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: trigger featureChanged on feature props change #1201

Merged

stepankuzmin merged 1 commit into mapbox:main from petermoz:prop-update

Dec 11, 2023

Commits on Oct 4, 2023

fix: trigger featureChanged on feature props change

mapbox#1196 intended to add a call to
`featureChanged` any time a feature was `add()`ed with modified
properties, however it has a bug in that the check came after assignment.

A simpler fix would be to move the assignment inside the `if()` body,
but that could break other code that depended on referential equality
after calling `add()`.

peter-greenatlas committed Oct 4, 2023