Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collator arguments shouldn't be camel-cased #6592

Closed
ChrisLoer opened this issue May 2, 2018 · 0 comments
Closed

Collator arguments shouldn't be camel-cased #6592

ChrisLoer opened this issue May 2, 2018 · 0 comments
Assignees
@ChrisLoer
Labels
release blocker ⛔
Milestone
0.45.0

Comments

@ChrisLoer
Copy link
Contributor

@jfirebaugh caught that we named them caseSensitive and diacriticSensitive instead of case-sensitive and diacritic-sensitive. Luckily we haven't publicly shipped them yet! 😅

/cc @anandthakker @samanpwbb
@ChrisLoer ChrisLoer added this to the 0.45.0 milestone May 2, 2018
@ChrisLoer ChrisLoer self-assigned this May 2, 2018
ChrisLoer added a commit that referenced this issue May 2, 2018
@ChrisLoer
"case/diacriticSensitive" -> "case/diacritic-sensitive"
cf92f0f 
Issue #6592.
@ChrisLoer ChrisLoer mentioned this issue May 2, 2018
Merged
ChrisLoer added a commit that referenced this issue May 2, 2018
@ChrisLoer
"case/diacriticSensitive" -> "case/diacritic-sensitive"
59eef94 
Issue #6592.
ChrisLoer added a commit that referenced this issue May 2, 2018
@ChrisLoer
"case/diacriticSensitive" -> "case/diacritic-sensitive"
b730721 
Issue #6592.
ChrisLoer added a commit that referenced this issue May 2, 2018
@ChrisLoer
"case/diacriticSensitive" -> "case/diacritic-sensitive"
49d5706 
Issue #6592.
@ChrisLoer ChrisLoer mentioned this issue May 2, 2018
Merged
4 tasks
ChrisLoer added a commit that referenced this issue May 2, 2018
@ChrisLoer
"case/diacriticSensitive" -> "case/diacritic-sensitive"
6a457ed 
Issue #6592.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChrisLoer ChrisLoer

Labels
release blocker ⛔
Projects
None yet
Milestone
0.45.0
Development

No branches or pull requests
2 participants
@jfirebaugh @ChrisLoer