Cherry pick 'collator' fixes #6598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although the results shouldn't change between evaluations, they may change between environments, so we don't want constant folding to make serializations that are inconsistent on different machines. `CollatorExpression#serialize` was not previously used by the test suite because of constant folding, and was broken -- it needed to explicitly serialize its children.
We no longer constant-fold Collator expressions, so there's no way to create a literal holding a Collator.
anandthakker
approved these changes
May 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #6592 -- don't use camel case in expression argument names. This is important to get into release-0.45 because after it's publicly released any further change would be a breaking change to the style-spec.
Also pulls in changes to avoid constant-folding of collator objects. Because the same collator can give different results between environments, constant-folding of expressions that rely on a collator is not appropriate (at least during serialization).
Launch Checklist
@mapbox/studioand/or@mapbox/maps-designif this PR includes style spec changes/cc @anandthakker @jfirebaugh @mapbox/studio @mapbox/maps-design