-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add poles support in getBounds
on the Globe
#12315
Conversation
b2c4ccf
to
b119593
Compare
getBounds
on the GlobegetBounds
on the Globe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work Stepan! Just a few nits.
Co-authored-by: Aidan H <aidan.hendrickson@mapbox.com>
26e07c2
to
a97ce33
Compare
@SnailBones @stepankuzmin Should we cherry-pick that fix in the beta so it's available in final? |
EDT: Misunderstood @karimnaaji`s proposal, I think this is low-risk enough that we could release it directly into the final without another beta. Though I'd be curious to your thoughts @stepankuzmin |
This should be a low risk to push it into the final release, but this might affect the existing users with the globe enabled. So we might play safe and ship it into beta to see if there is any feedback on the new behavior. Anywise, I'm okay to push it to the final release @karimnaaji @SnailBones |
This PR adds the pole support in
getBounds
on the Globe. It adds a new util functionpolesInViewport
, that detects if the poles are visible in the current viewport by intersecting the location with the viewport in screen coordinates and checking if they are behind the globe surface.Previously the poles support was removed in #12318
Before
After
Launch Checklist
mapbox-gl-js
changelog:<changelog>Improve poles support in getBounds when projection is set to globe</changelog>