Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert the poles support in Globe getBounds #12318

Merged
merged 3 commits into from
Oct 19, 2022
Merged

Revert the poles support in Globe getBounds #12318

merged 3 commits into from
Oct 19, 2022

Conversation

stepankuzmin
Copy link
Contributor

This PR reverts the poles support in Globe getBounds added in #12286

Launch Checklist

  • briefly describe the changes in this PR
  • document any changes to public APIs
  • apply changelog label ('bug', 'feature', 'docs', etc) or use the label 'skip changelog'

@stepankuzmin stepankuzmin added the skip changelog Used for PRs that do not need a changelog entry label Oct 19, 2022
@stepankuzmin stepankuzmin requested a review from a team as a code owner October 19, 2022 16:29
SnailBones
SnailBones reviewed Oct 19, 2022
View reviewed changes
src/ui/map.js Outdated Show resolved Hide resolved
SnailBones
SnailBones approved these changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@SnailBones SnailBones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@stepankuzmin @SnailBones
Update src/ui/map.js
24e969f 
Co-authored-by: Aidan H <aidan.hendrickson@mapbox.com>
@stepankuzmin stepankuzmin merged commit c9c868b into main Oct 19, 2022
@stepankuzmin stepankuzmin deleted the revert-getBounds-warning-on-Globe branch October 19, 2022 19:59
@stepankuzmin stepankuzmin mentioned this pull request Oct 20, 2022
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SnailBones SnailBones SnailBones approved these changes

Assignees
No one assigned
Labels
skip changelog Used for PRs that do not need a changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stepankuzmin @SnailBones