Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve text-max-angle check #1959

Merged
merged 1 commit into from
Jan 21, 2016
Merged

improve text-max-angle check #1959

merged 1 commit into from
Jan 21, 2016

Conversation

ansis
Copy link
Contributor

@ansis ansis commented Jan 20, 2016

Instead of using the absolute value of the sum of angles, use the sum of the absolute values of angles.

This helps avoid labels on lines with sharp zig zags.

for example, the "Central Campus Mall" label here:
mapbox/mapbox-gl-native#2998

test-suite update: https://github.com/mapbox/mapbox-gl-test-suite/tree/max-angle-fix

@lucaswoj can you review?

Instead of using the absolute value of the sum of angles, use the sum of
the absolute values of angles.

This helps avoid labels on lines with sharp zig zags.

for example, the "Central Campus Mall" label here:
mapbox/mapbox-gl-native#2998
@ansis ansis changed the title improve symbol-max-angle check improve text-max-angle check Jan 21, 2016
@ansis ansis merged commit e2ee728 into master Jan 21, 2016
@ansis ansis removed the in progress label Jan 21, 2016
@ansis ansis deleted the max-angle branch January 21, 2016 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant