Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

bad label collision #2998

Closed
jfirebaugh opened this issue Nov 10, 2015 · 1 comment
Closed

bad label collision #2998

jfirebaugh opened this issue Nov 10, 2015 · 1 comment
Assignees
@ansis

Comments

@jfirebaugh
Copy link
Contributor

The label collision in the top left seen here does not seem to happen in the same style viewed with gl-js. Needs investigation.

mapbox-bad-labels
@ansis ansis self-assigned this Jan 15, 2016
ansis added a commit to mapbox/mapbox-gl-js that referenced this issue Jan 20, 2016
@ansis
improve symbol-max-angle check
e2ee728 
Instead of using the absolute value of the sum of angles, use the sum of
the absolute values of angles.

This helps avoid labels on lines with sharp zig zags.

for example, the "Central Campus Mall" label here:
mapbox/mapbox-gl-native#2998
@ansis ansis mentioned this issue Jan 20, 2016
Merged
@ansis ansis mentioned this issue Jan 21, 2016
Merged
ansis added a commit that referenced this issue Jan 21, 2016
@ansis
[core] improve text-max-angle check
ed0488d 
Instead of using the absolute value of the sum of angles, use the sum of
the absolute values of angles.

This helps avoid labels on lines with sharp zig zags.

for example, the "Central Campus Mall" label in issue #2998
@ansis
Copy link
Contributor

ansis commented Jan 21, 2016

#3623 fixes the "University of Colorado Boulder" collision. The style uses symbol-avoid-edges and it was taking a shortcut that assumes symbol-avoid-edges is working.

#3640 fixes the "Central Campus Mall" bug

@ansis ansis closed this as completed Jan 21, 2016
@ansis ansis mentioned this issue Jan 21, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ansis ansis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jfirebaugh @ansis