Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle 'Not Found' errors to allow 'loaded' event #1985

Closed
wants to merge 3 commits into from

Conversation

laurenancona
Copy link

We've been running our own fork with this patch since 0.11.0 because the errors prevent loaded from returning true. Still results in noisy logs, but find it preferable to silent failure while debugging.

Closes #1800.

@lucaswoj
Copy link
Contributor

Thank you for the PR @laurenancona!

Next Steps

  • create an ajax.Error error class with statusText and statusCode properties (requires changing both util/ajax and util/browser/ajax)
  • check for error instanceof ajax.Error && error.statusCode === 404 before silently dismissing the error
  • squash into one commit

@laurenancona
Copy link
Author

Excellent, thanks @lucaswoj. We're taking a shot at it. 🔫

@lucaswoj
Copy link
Contributor

Thank you @laurenancona! Ping me in Slack if you have any questions!

@lucaswoj
Copy link
Contributor

Replaced by #2176

@lucaswoj lucaswoj closed this Feb 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants