Add icon-pitch-alignment property
#4869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisLoer
force-pushed
the
cloer_icon_pitch_alignment
branch
from
a639058
to
3bc599a
Compare
8 tasks
lora-reames
added a commit
to lora-reames/DefinitelyTyped
that referenced
this pull request
Aug 28, 2017
Add new icon-pitch-alignment and circle-pitch-alignment properties mapbox/mapbox-gl-js#4869 mapbox/mapbox-gl-js#4871
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following discussion at #4120, adds an
icon-pitch-alignmentproperty that follows the same behavior astext-pitch-alignment. Existing behavior is that icon pitch alignment just matches icon rotation alignment (map or viewport).#4120 (comment) is requesting
circle-pitch-alignment, but it hints at how the same property could be useful for icons -- you might want to place an icon "flat" on the map to go under something else, but still have the icon oriented "upright" (ie "viewport aligned").This PR depends on #4864 going in first, because it adds a test that fails without the fix for #4860 (in fact this is how I discovered #4860)./cc @ansis @nickidlugash