Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Build Location Picker Example In TestApp #5282

Closed
bleege opened this issue Jun 8, 2016 · 21 comments
Closed

Build Location Picker Example In TestApp #5282

bleege opened this issue Jun 8, 2016 · 21 comments
Assignees
Labels
Android Mapbox Maps SDK for Android

Comments

@bleege
Copy link
Contributor

bleege commented Jun 8, 2016

A common use case for apps is to have a Location Picker over a map and while the TestApp has the basics of this already in the GeocoderActivity it can be enhanced to mirror the functionality that traditionally is part of this use case as well as made more discoverable. Specifically, this example should have:

  • A Marker (pin) that is centered in the middle of the screen that moves as the user pans around the map
  • An animation should be triggered on the UserLocationView when the Marker is moved over it to indicate that the Marker and User Location have come into alignment.
  • An InfoWindow for the Marker that displays the address of the selected location
  • Once a location is selected via Marker all zoom events should be centered on the Marker's location.
@bleege bleege added the Android Mapbox Maps SDK for Android label Jun 8, 2016
@bleege bleege added this to the android-v4.2.0 milestone Jun 8, 2016
@bleege bleege self-assigned this Jun 8, 2016
bleege added a commit that referenced this issue Jun 10, 2016
bleege added a commit that referenced this issue Jun 10, 2016
@bleege
Copy link
Contributor Author

bleege commented Jun 10, 2016

When getting ready to hook up the Geocoder I noticed that the TestApp is still running the old school (and deprecated) Mapbox Directions and Mapbox Geocoding libraries and not Mapbox Android Services as it should be these days. Before I can build the Location Picker I need to do a little house cleaning and get things ported to MAS.

bleege added a commit that referenced this issue Jun 10, 2016
bleege added a commit that referenced this issue Jun 10, 2016
@bleege
Copy link
Contributor Author

bleege commented Jun 10, 2016

I've got the basic UI of Location Picker built, namely pan map using a marker, select location, geocode location, display address with Marker and opened InfoWindow. To finish this part of the requirements off I need to:

  • Add Reset To Geocoding Search Mode UI
  • Fix Pin Alignment so that Search Pin to Results Pin is seamless
  • Improve Address Formatting in the InfoWindow

Once these are done the next steps are to add the User Dot, User Dot animation, and Zoom events to be centered on Results Pin location.

2016-06-10 14_52_00

/cc @zugaldia

@bleege
Copy link
Contributor Author

bleege commented Jun 10, 2016

Shortening the displayed geocoded data in the InfoWindow from the full address to simply the Street Number and Street Name makes the InfoWindow more manageable as well as better fit the use case. However, it also showed that fixing the empty snippet line is going to be a priority as well. This is documented in --> #4959

@bleege
Copy link
Contributor Author

bleege commented Jun 11, 2016

Current status of the UI (see gif below). Next up is to get the marker to line up better between Search Mode and Display Mode. After that all that remains is the Over User Location animation and zoom to Display Pin gesture support.

2016-06-10 19_02_19

@tobrun
Copy link
Member

tobrun commented Jun 13, 2016

Once a location is selected via Marker all zoom events should be centered on the Marker's location.

The code to make this happen is being picked up as a a part of focal point configuration in #4924 and PR'ed in #5332. After that lands you can rebase this branch on release-4.1.0

An animation should be triggered on the UserLocationView when the Marker is moved over it to indicate that the Marker and User Location have come into alignment.

I will create some example code so you can copy paste it into this one.

@bleege
Copy link
Contributor Author

bleege commented Jun 13, 2016

From this morning's team discussion here's the game plan for finishing this ticket:

  1. Fix Marker placement
  2. Land Focal Point zoom
  3. Hover Animation over User Location ( AddCircle method for map, support modify radius of circle #4153 )
  4. Remove extra InfoWindow space on InfoWindow with empty snipper ( Extra space on an InfoWindow without a snippet #4959 )

@bleege
Copy link
Contributor Author

bleege commented Jun 13, 2016

Marker place is now good to go!

2016-06-13 11_58_55

@bleege
Copy link
Contributor Author

bleege commented Jun 13, 2016

Picking up InfoWindow #4959 while waiting for #5332 to land.

@zugaldia
Copy link
Member

Example added via #5391.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Development

No branches or pull requests

4 participants