assert(uv_thread_self() == map_thread)

[mikemorris]

These asserts (scattered throughout a few different files) should not be expected to pass when the Map::render is intentionally called in a different thread than where the map object was initially created (such as an async render method in Node.js bindings). I saw some logic around an async_render function, but that seems to be tied into the libuv implementation in mapbox-gl-native a bit too closely. Should this either be refactored for external use, or should these asserts be conditionally disabled some other way?

[ljbade]

Yeah came across this problem in a few places with other functions.

[mikemorris]

In the cli-render branch, the problematic asserts only seem to be present on BUILDTYPE=Debug installs now, fixed by 57e6bc6. Is there a better way to patch this to still be able to get debug symbols in Node.js bindings though @kkaefer? I'm guessing Mode::Static from 21e9e0a might be part of the answer.

[mikemorris]

Doh, this is apparently only happening in Debug builds? Just ran against a Release build of master without tripping any asserts.

[ljbade]

@mikemorris assert() compiles to a noop on Release builds

[mikemorris]

Hah, that would do it, was that a recent change or has it always been that way @ljbade?

[incanus]

That's pretty common native behavior.

[kkaefer]

asserts are always compiled out on Release builds.