Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

CLI render #718

Merged
merged 11 commits into from
Dec 19, 2014
Merged

CLI render #718

merged 11 commits into from
Dec 19, 2014

Conversation

kkaefer
Copy link
Contributor

@kkaefer kkaefer commented Dec 12, 2014

Adds a CLI binary that allows rendering static images.

Fixes #623

@kkaefer
Copy link
Contributor Author

kkaefer commented Dec 12, 2014

Current performance breakdown of rendering a 512x512 Kottbusser Tor tile:

  • 62% label placement
  • 6% tessellation
  • 8% shader compilation
  • 5% PNG compression

The actual tile took about 240ms to render (and about 380 CPU milliseconds).

@freenerd
Copy link

\o/

@kkaefer
Copy link
Contributor Author

kkaefer commented Dec 12, 2014

Note that this isn't node.js-related, and doesn't parallelize anything.

@mikemorris
Copy link
Contributor

Wooo, nice to see this moving!


int main(int argc, char *argv[]) {

std::string style_path;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we were using camel case now?

@jfirebaugh
Copy link
Contributor

Looks like headless rendering tests are universally failing on this branch. For comparison, at least some are passing on current master.

@mikemorris
Copy link
Contributor

Whoa @jfirebaugh , that looks like what I was seeing from multithreading problems with mixed up contexts at one point. FWIW 57e6bc6 was last known working commit for me.

@mikemorris
Copy link
Contributor

Huh, just tested with HEAD of cli-render and I'm not able to reproduce those failures in Release or Debug builds on OS X or Ubuntu 14.04 @jfirebaugh

@mikemorris
Copy link
Contributor

Um, I'm also not seeing a build 1705 (the one that would have generated those failing tests you linked) on Travis @jfirebaugh https://travis-ci.org/mapbox/mapbox-gl-native/builds

@jfirebaugh
Copy link
Contributor

Oops, I guess I followed a link from an old commit. https://travis-ci.org/mapbox/mapbox-gl-native/builds/43837521

Most recent build looks equivalent to master. http://mapbox-gl-testing.s3.amazonaws.com/headless/mapbox/mapbox-gl-native/1719.1/index.html

jfirebaugh added a commit that referenced this pull request Dec 19, 2014
@jfirebaugh jfirebaugh merged commit 4a2cf4a into master Dec 19, 2014
@jfirebaugh jfirebaugh deleted the cli-render branch December 19, 2014 02:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

assert(uv_thread_self() == map_thread)
5 participants