Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[ios] Run MGLMapboxEvents setup asynchronously #11784

Merged
merged 6 commits into from
May 22, 2018
Merged

Conversation

rclee
Copy link
Contributor

@rclee rclee commented Apr 26, 2018

Reduces lag from events library setup.

@rclee rclee self-assigned this Apr 26, 2018
@rclee rclee requested review from akitchen and 1ec5 April 26, 2018 20:27
@friedbunny friedbunny added this to the ios-v4.0.1 milestone Apr 27, 2018
@friedbunny friedbunny added iOS Mapbox Maps SDK for iOS performance Speed, stability, CPU usage, memory usage, or power usage labels Apr 27, 2018
Copy link
Contributor

@1ec5 1ec5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps add a blurb to the iOS changelog about reducing startup time.

@friedbunny
Copy link
Contributor

This change appears to have been applied on top of a somewhat old branch from release-boba that doesn’t know about several CI builds — @rclee you’ll want to rebase rclee-async-setup onto the most current release-boba and force push rclee-async-setup to kickstart those tests.

@@ -12,6 +12,7 @@ Mapbox welcomes participation and contributions from everyone. Please read [CONT

* Fixed an issue where `-[MGLMapView metersPerPixelAtLatitude:]` was removed, but not marked as unavailable. ([#11765](https://github.com/mapbox/mapbox-gl-native/pull/11765))
* Fixed an issue where selecting an onscreen annotation could move the map unintentionally. ([#11731](https://github.com/mapbox/mapbox-gl-native/pull/11731))
* Reduced startup time by causing MGLMapboxEvents to be setup asynchronously. (https://github.com/mapbox/mapbox-gl-native/pull/11784)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changelog’s audience is developers who install the SDK. MGLMapboxEvents isn’t a public class, so let’s leave it at:

Improved application launch performance.

@1ec5 1ec5 modified the milestones: ios-v4.0.1, ios-v4.0.2, ios-v4.1.0 May 8, 2018
@1ec5
Copy link
Contributor

1ec5 commented May 15, 2018

This PR is currently scheduled for iOS map SDK v4.1.0, so the branch needs to be rebased atop master.

@rclee rclee changed the base branch from release-boba to master May 22, 2018 18:06
@rclee rclee merged commit 8a02fa4 into master May 22, 2018
@rclee rclee deleted the rclee-async-setup branch May 22, 2018 19:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
iOS Mapbox Maps SDK for iOS performance Speed, stability, CPU usage, memory usage, or power usage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants