Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[ios] Update changelog for v4.1.0-beta.1 #12086

Merged
merged 1 commit into from
Jun 11, 2018

Conversation

fabian-guerra
Copy link
Contributor

Podspec bump and changelog updates.

@fabian-guerra fabian-guerra self-assigned this Jun 7, 2018
@friedbunny
Copy link
Contributor

friedbunny commented Jun 7, 2018

There are a variety of core changes that weren’t (and should have been) changelog’d — see the needs changelog label for some of the ones I’ve noticed recently.

@friedbunny friedbunny added iOS Mapbox Maps SDK for iOS build labels Jun 7, 2018
@friedbunny friedbunny added this to the ios-v4.1.0 milestone Jun 7, 2018
@fabian-guerra fabian-guerra force-pushed the fabian-ios-v4.1.0-beta.1 branch 2 times, most recently from 75e9241 to b42cfcd Compare June 11, 2018 17:51
@fabian-guerra
Copy link
Contributor Author

For some reason the podspec bump got caught in CP this #12087

@friedbunny friedbunny changed the title [ios] Bump podspec to v4.1.0-beta.1 [ios] Update changelog for v4.1.0-beta.1 Jun 11, 2018
@@ -21,6 +23,9 @@ Mapbox welcomes participation and contributions from everyone. Please read [CONT
* Added custom `-hitTest:withEvent:` to `MGLSMCalloutView` to avoid registering taps in transparent areas of the standard annotation callout. ([#11939](https://github.com/mapbox/mapbox-gl-native/pull/11939))
* Improved performance and memory impact of `MGLScaleBar`. ([#11921](https://github.com/mapbox/mapbox-gl-native/pull/11921))
* Fixed race conditions that could cause crashes when re-using `MGLMapSnapshotter` or using multiple snapshotters at the same time. ([#11831](https://github.com/mapbox/mapbox-gl-native/pull/11831))
* Fixed an issue where an empty `MGLFeature`s array caused high CPU utilization. ([#11985](https://github.com/mapbox/mapbox-gl-native/pull/11985))
* Improved offline download. ([#11284](https://github.com/mapbox/mapbox-gl-native/pull/11284))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s be a little more specific and say: “download performance.”

@@ -21,6 +23,9 @@ Mapbox welcomes participation and contributions from everyone. Please read [CONT
* Added custom `-hitTest:withEvent:` to `MGLSMCalloutView` to avoid registering taps in transparent areas of the standard annotation callout. ([#11939](https://github.com/mapbox/mapbox-gl-native/pull/11939))
* Improved performance and memory impact of `MGLScaleBar`. ([#11921](https://github.com/mapbox/mapbox-gl-native/pull/11921))
* Fixed race conditions that could cause crashes when re-using `MGLMapSnapshotter` or using multiple snapshotters at the same time. ([#11831](https://github.com/mapbox/mapbox-gl-native/pull/11831))
* Fixed an issue where an empty `MGLFeature`s array caused high CPU utilization. ([#11985](https://github.com/mapbox/mapbox-gl-native/pull/11985))
* Improved offline download. ([#11284](https://github.com/mapbox/mapbox-gl-native/pull/11284))
* Fixed an issue that caused `MGLMapView visibleFeaturesAtPoint:]` return an empty features array when removing/adding features. ([#12076](https://github.com/mapbox/mapbox-gl-native/pull/12076))
Copy link
Contributor

@friedbunny friedbunny Jun 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small tweaks:

Fixed an issue that caused -[MGLMapView visibleFeaturesAtPoint:] to return an empty array when adding or removing features.

@@ -11,6 +11,8 @@ Mapbox welcomes participation and contributions from everyone. Please read [CONT
### Style layers

* Added support for aggregate expressions as input values to `MGL_MATCH` expressions. ([#11866](https://github.com/mapbox/mapbox-gl-native/pull/11866))
* Fixed a crash caused by `literal` expressions when used in non-data-driven properties. ([#11960](https://github.com/mapbox/mapbox-gl-native/pull/11960))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix made it into ios-v4.0.2 (via #11961), so we don’t need to changelog it here.

@friedbunny
Copy link
Contributor

Found another one: this line should link to its GitHub issue, so we need to add a link to #11784.

https://github.com/mapbox/mapbox-gl-native/blame/c48bdcde7553b34dc9dbbd0c41cb31997044b0bd/platform/ios/CHANGELOG.md#L20

@friedbunny
Copy link
Contributor

friedbunny commented Jun 11, 2018

#12076 (#12100) also needs a changelog.

My mistake, we already got this. 🙇

@fabian-guerra fabian-guerra merged commit d0afb6d into release-chai Jun 11, 2018
@fabian-guerra fabian-guerra deleted the fabian-ios-v4.1.0-beta.1 branch June 11, 2018 20:07
@1ec5
Copy link
Contributor

1ec5 commented Jun 20, 2018

Going forward, changes such as these need to be merged to master first, then cherry-picked to the release branch. The release-chai branch won’t be merged back to master, so #12185 cherry-picks these changes into master.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
build iOS Mapbox Maps SDK for iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants