This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkaefer
force-pushed
the
1272-render-still-images-on-thread
branch
from
April 16, 2015 09:11
1c62246
to
6ccbd35
Compare
mikemorris
force-pushed
the
1272-render-still-images-on-thread
branch
from
April 16, 2015 11:09
6ccbd35
to
728001d
Compare
mikemorris
added a commit
to cutting-room-floor/node-mapbox-gl-native
that referenced
this pull request
Apr 16, 2015
Seeing uncaught exceptions in style parsing that seem to be happening asynchronously and as such are not being caught as expected. The following crash pops up during
|
kkaefer
referenced
this pull request
Apr 16, 2015
This brings the easing transition code a bit closer to how easings work in gl-js. Instead of having an array of individual transitions for scale, rotate, and pan, there is a single transition function that does all the required calculations. This permits us to: * Eliminate the "timeout" transition. (Fixes #126) * Replace start/stopPanning() et al with setGestureInProgress(). Apps or SDKs are expected to make paired calls to setGestureInProgress(). This state will be ORed with the active easing state to determine when to use texture interpolation. (Fixes #79) * Run style recalculations only when an ease transition that affects the zoom is in progress. (Fixes #1155)
We still need to rework the interface to fix #1273 so that whenever we trigger a static image render, all of the options are set atomically so that we know the size of the view before we are loading data to render the tile. |
- static rendering now also runs in a separate thread; you have to start it with map.start(Map::Mode::Static) and join the thread with map.stop() before destructing the Map object - map.renderStill() takes a callback with will be invoked on the *map* thread, so you'll have to figure out your own method of dispatching back to the main thread.
- this is only a stopgap; we need to properly pass state between threads - doesn't fix changing the pixel ratio
kkaefer
force-pushed
the
1272-render-still-images-on-thread
branch
from
April 17, 2015 11:41
ddfd988
to
60a0e8a
Compare
kkaefer
added a commit
that referenced
this pull request
Apr 17, 2015
Render still/static images on a separate thread as well, aligning it with the way continuous render mode works
mikemorris
added a commit
to cutting-room-floor/node-mapbox-gl-native
that referenced
this pull request
Apr 17, 2015
mikemorris
added a commit
to cutting-room-floor/node-mapbox-gl-native
that referenced
this pull request
Apr 17, 2015
mapbox/mapbox-gl-native#1272 Some tests are hanging with no errors or log messages when map.load is passed a style but never rendered.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull work and ideas from the
static-render
branch intomaster
so we can render static images for node-mapbox-gl-native./cc @kkaefer