This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[Core] Add tests for bounding boxes that cross the antimeridian #13087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 24, 2018
Closed
|
This pull request has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions. |
|
Would you still like to merge these tests @ryanhamley @ansis? |
|
This pull request has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions. |
|
@ryanhamley FWIW we've recently fixed a couple of edge cases wrt bounds crossing the antimeridian here: #13958. That PR also included a bunch of following unit tests, which may overlap with the proposed ones here. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The behavior of bounding boxes that cross the antimeridian doesn't seem well-defined or well-coordinated across all our platforms. The vagueness is the source of several bugs and significant confusion. These tests should help define consistent behavior that will make reasoning about the problem easier while avoiding introducing new bugs.
cc @ansis