-
Notifications
You must be signed in to change notification settings - Fork 1.3k
LatLngBounds: Fix constrain when crossing antimeridian #13958
Conversation
a426268
to
dd61182
Compare
I've quickly tested this one and it works well for #13672, however, in contrast to #13906 it doesn't fix #13770 anymore. This is because when the gesture is I think the possible solution can be ignoring, or changing the behavior of the |
Good point @LukasPaczos - I think we can special case for whether camera bounds is present or not in that line 👍 |
28e51d7
to
6e56eee
Compare
78e4400
to
a360f2b
Compare
This PR also changes the behavior of the internal coordinates stored in Important to notice the unwrapped longitude value does not leak outside |
a360f2b
to
ed52e21
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 and thanks for for the explanation.
ed52e21
to
84fa1f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with minor nits
84fa1f1
to
266fd89
Compare
Great stuff! kudos |
This PR fixes the constraint behavior when crossing the antimeridian, but also:
This PR is an alternative to #13906.
Closes #13672, follow up from #13871
/cc @tobrun