This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Remove redundant radian-degree conversions #13212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianrex
approved these changes
Oct 26, 2018
|
Apparently this PR also fixes an issue with the user dot quite literally flipping out on a tilted map. /cc @friedbunny |
|
Indeed, this also fixes Jason’s Favorite Bug of the Year Nominee “Flippy Dot and the 3438 Degrees of Pitch”.
|
1ec5
commented
Oct 26, 2018
| @@ -1218,10 +1218,10 @@ - (void)flyToCamera:(MGLMapCamera *)camera withDuration:(NSTimeInterval)duration | |||
| camera.centerCoordinate.latitude, | |||
| self.frame.size); | |||
| if (camera.heading >= 0) { | |||
| options.angle = MGLRadiansFromDegrees(-camera.heading); | |||
| options.angle = -camera.heading; | |||
There was a problem hiding this comment.
I missed this negative sign: #13213.
springmeyer
reviewed
Nov 8, 2018
There was a problem hiding this comment.
@1ec5 - would it be possible to add a test for this code to prevent the possibility it could regress again after core changes?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed several radian-to-degree or degree-to-radian conversions in iOS and macOS map SDK code that were made redundant by #13123, resulting in incorrect map camera rotation and tilting on both platforms. Also added changelog entries for bugs inadvertently fixed by #13123.
Fixes #13210.
/cc @julianrex @brunoabinader