This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Fix sign flip in programmatic camera rotation #13213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed an issue where the mbgl::CameraOptions’ heading was misinterpreted as going counterclockwise instead of clockwise.
friedbunny
approved these changes
Oct 29, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to #13212 that fixes an issue where the
mbgl::CameraOptions’ heading was misinterpreted as going counterclockwise instead of clockwise. I had removed the redundant negative sign from the iOS implementation but accidentally left it in the macOS implementation./cc @julianrex @friedbunny