This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Adjust coverage tracking threshold #13364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
springmeyer
force-pushed
the
coverage-tolerance
branch
from
a751a7b
to
bcb0796
Compare
|
I think this should merge now, but my jobs are hitting: Since these are unrelated, can this still be merged? |
friedbunny
approved these changes
Dec 1, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the default threshold to 1% (from
0%) for when to fail a build due to negative coverage changes.The reasoning here is that some tests are unreliable (more on this at #13324) and are causing %0.1 fluctuations in coverage for PRs which should not impact coverage (like #13357 and #13360). This change is a stopgap measure to avoid developer pain, until the cause of the unreliability can be understood and mitigated.
/cc @jmkiley
Docs for adjusting thresholds at https://docs.codecov.io/docs/commit-status