Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

OnlineFileSource.LowHighPriorityRequests test is flaky #13371

Closed
kkaefer opened this issue Nov 14, 2018 · 0 comments
Closed

OnlineFileSource.LowHighPriorityRequests test is flaky #13371

kkaefer opened this issue Nov 14, 2018 · 0 comments
Assignees
@alexshalamov
Labels
Core The cross-platform C++ core, aka mbgl tests

Comments

@kkaefer
Copy link
Member

kkaefer commented Nov 14, 2018

I'm sometimes observing this test failure on CI, in particular on Qt builds (e.g. https://circleci.com/gh/mapbox/mapbox-gl-native/197671):

[ RUN      ] OnlineFileSource.LowHighPriorityRequests
../../../test/storage/online_file_source.test.cpp:446: Failure
      Expected: response_counter
      Which is: 1
To be equal to: NUM_REQUESTS
      Which is: 3
@kkaefer kkaefer added tests Core The cross-platform C++ core, aka mbgl labels Nov 14, 2018
@springmeyer springmeyer mentioned this issue Nov 30, 2018
Merged
@asheemmamoowala asheemmamoowala mentioned this issue Dec 11, 2018
Closed
@friedbunny friedbunny mentioned this issue Jan 10, 2019
Closed
@alexshalamov alexshalamov self-assigned this Jan 11, 2019
alexshalamov added a commit that referenced this issue Jan 11, 2019
@alexshalamov
[core] Fix flaky OnlineFileSource.LowHighPriorityRequests
f29aa05 
When network status is changed to online, all unqueued requests may
be processed in nondeterministic. Therefore, low-priority request may
be made active, while other are put to priority queue. This introduces
flakiness for the unit test.

Fixes: #13371
@alexshalamov alexshalamov mentioned this issue Jan 11, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexshalamov alexshalamov

Labels
Core The cross-platform C++ core, aka mbgl tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kkaefer @alexshalamov