Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Instrumented unit tests, add map tests, refactor gen layer tests #13443

Merged
merged 2 commits into from
Dec 11, 2018

Conversation

tobrun
Copy link
Member

@tobrun tobrun commented Nov 23, 2018

Refs #13418
This PR introduces a way to perform unit tests on JNI/core integration.
It runs instrumented unit tests without using a view hierarchy/activity/espresso:

  • adds basic map tests
  • refactors generated layer tests

@tobrun tobrun added the Android Mapbox Maps SDK for Android label Nov 23, 2018
@tobrun tobrun added this to the android-v7.0.0-iowaska milestone Nov 23, 2018
@tobrun tobrun self-assigned this Nov 23, 2018
@tobrun tobrun requested a review from LukasPaczos November 23, 2018 14:46
@tobrun tobrun force-pushed the tvn-redoing-testing branch from bc3d11c to d1de3af Compare November 23, 2018 14:49
Copy link
Contributor

@LukasPaczos LukasPaczos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome 🚀

@tobrun
Copy link
Member Author

tobrun commented Nov 23, 2018

With this change firebase execution time is already dropping from 12 to 8 minutes

@tobrun tobrun force-pushed the tvn-redoing-testing branch from d1de3af to 5b8bdaa Compare November 26, 2018 14:39
@tobrun tobrun force-pushed the tvn-redoing-testing branch 2 times, most recently from 47bbe9a to 1629dde Compare December 5, 2018 15:59
@tobrun
Copy link
Member Author

tobrun commented Dec 5, 2018

rebased this PR to pull in 794b851

@tobrun
Copy link
Member Author

tobrun commented Dec 11, 2018

Initially this PR contained breaking changes to the public API (changing padding to float[] vs int[]), reverting those so we don't need to ship this with upcoming semver major.

@tobrun tobrun force-pushed the tvn-redoing-testing branch 2 times, most recently from 5586066 to 6b25387 Compare December 11, 2018 10:27
@tobrun tobrun force-pushed the tvn-redoing-testing branch from 6b25387 to ef50130 Compare December 11, 2018 10:37
@tobrun tobrun merged commit 75914ac into master Dec 11, 2018
@tobrun tobrun deleted the tvn-redoing-testing branch December 11, 2018 17:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants