This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Move MapboxMapTest to java unit test #13542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobrun
force-pushed
the
tvn-move-mapboxmaptest-to-unit
branch
from
dc5aefd to
b5f0ecb
Compare
tobrun
force-pushed
the
tvn-move-mapboxmaptest-to-unit
branch
from
b5f0ecb to
9e92655
Compare
Updated this PR to not delete those annotation tests |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #13418, this PR migrates our exisiting instrumented MapboxMapTest to a java unit test.
It validates the path executed by the java code until it hits the jni boundary. Testing of the jni boundary to core is handled by #13443. Since we deprecated annotations, I opted to not port those testcases.