This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
CameraMode transition animation and result listeners #13523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasPaczos
force-pushed
the
lp-13243-location-transition-handler
branch
3 times, most recently
from
10842e7
to
f8fe497
Compare
tobrun
reviewed
Dec 10, 2018
...MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/location/LocationCameraController.java
Show resolved
Hide resolved
danesfeder
approved these changes
Dec 10, 2018
There was a problem hiding this comment.
@LukasPaczos this looks good to me 👍 agree with @tobrun that adding some tests that verify correct callback trigger would be 💯
LukasPaczos
force-pushed
the
lp-13243-location-transition-handler
branch
from
c05077e
to
b4d9266
Compare
|
Tests have been revisited and I'd love another round of 👀 on them if possible before merging, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13243.