This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Save debug cache state vs map state #13638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasPaczos
approved these changes
Dec 21, 2018
platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/maps/MapView.java
Outdated
Show resolved
Hide resolved
tobrun
force-pushed
the
tvn-cache-debug-state
branch
from
6d9b8de
to
a795e6d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing #13560. I'm noticing that a fragment can call onSaveInstanceState when it's in the fragment backstack. This means that the view and underlying NativeMapView have already been destroyed and we shouldn't talk to NativeMapView to save state. This PR caches the debug value so it can be restored on orientation change without NativeMapView involvement.