This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Verify no native method is called when saving state #13980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13560.
After investigating the potential map leak it turns out that calls to the
MapViewfrom a fragment that's in a backstack can be justified in order to save state. Because the system is not going to dispatch save state calls when the view is being destroyed, the only chance to save state for a fragment that contains a map can be when it's already been replaced during a transition.The only thing we need to ensure is that during saving state process there are no calls to the native peer, because the renderer can already be destroyed, which has already been done in #13638, this PR adds a test for that case.