This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core] Notify requests about network reachability in priority order #13721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkaefer
reviewed
Jan 11, 2019
|
@kkaefer I can reproduce the issue quite reliably, for example with filter I can draft PR that will process requests according to the priority when connectivity status is changed to online. |
alexshalamov
force-pushed
the
alexshalamov_fix_flaky_onlinefilesource
branch
from
f29aa05 to
c0c1c73
Compare
alexshalamov
changed the title
alexshalamov
force-pushed
the
alexshalamov_fix_flaky_onlinefilesource
branch
from
c0c1c73 to
f577e43
Compare
|
@kkaefer could you please take a look? |
kkaefer
reviewed
Jan 14, 2019
alexshalamov
force-pushed
the
alexshalamov_fix_flaky_onlinefilesource
branch
from
f577e43 to
4bdfd38
Compare
kkaefer
approved these changes
Jan 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When network status is changed to online, all unqueued requests may be processed in nondeterministic. order (unordered_set). Therefore, low-priority request may be made active, while other are put to priority queue. This introduces flakiness for the unit test.
Fixes: #13371