This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[android] Adding new variation of LocationComponent#activateLocationComponent #13829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasPaczos
reviewed
Jan 30, 2019
...roid/MapboxGLAndroidSDK/src/test/java/com/mapbox/mapboxsdk/location/LocationComponentTest.kt
Outdated
Show resolved
Hide resolved
...roid/MapboxGLAndroidSDK/src/test/java/com/mapbox/mapboxsdk/location/LocationComponentTest.kt
Outdated
Show resolved
Hide resolved
|
Ok @LukasPaczos , I think I correctly adjusted the test based on your feedback. Take a look when you get a chance 👍 |
LukasPaczos
reviewed
Jan 30, 2019
...roid/MapboxGLAndroidSDK/src/test/java/com/mapbox/mapboxsdk/location/LocationComponentTest.kt
Show resolved
Hide resolved
langsmith
deleted the
ls-adding-locationcomponent-options-to-activation-method
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I looked into the pulsing
LocationComponentcircle functionality, I discovered that theLocationComponentcould use a new version of theactivateLocationComponent()method. There wasn't an activation method which took a certain mix of 5 parameters, which I've now added in this pr.