Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Limit the acceptable gestures offset if camera bounds are present #13897

Closed
wants to merge 1 commit into from
Closed

Limit the acceptable gestures offset if camera bounds are present #13897

wants to merge 1 commit into from

Conversation

LukasPaczos
Copy link
Member

@LukasPaczos LukasPaczos commented Feb 8, 2019 •
edited
Loading

Closes #13770.

ezgif com-video-to-gif 27

TODO:

  • test coverage
  • verify that there's no performance impact

@LukasPaczos LukasPaczos added the Android Mapbox Maps SDK for Android label Feb 8, 2019
@LukasPaczos LukasPaczos added this to the release-kombucha milestone Feb 8, 2019
@LukasPaczos
Copy link
Member Author

The execution of the additional logic takes:

  • Pixel 2 XL
    • ~0.03ms when bounds are not set
    • ~0.15ms when bounds are set
  • Xperia Z1
    • ~0.07ms when bounds are not set
    • ~0.44ms when bounds are set

Most of that time seems to be the JNI overhead.

@LukasPaczos LukasPaczos force-pushed the lp-13770-gestures-bounds branch 3 times, most recently from 38664b5 to 1f418a8 Compare February 11, 2019 15:44
@LukasPaczos
Copy link
Member Author

Obsolete with #13906 in place.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tobrun tobrun Awaiting requested review from tobrun

Assignees
No one assigned
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Milestone
release-kombucha
Development

Successfully merging this pull request may close these issues.
1 participant
@LukasPaczos