Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Change easeTo wrapping logic for constrained bounds #13906

Closed
wants to merge 1 commit into from

Conversation

tobrun
Copy link
Member

@tobrun tobrun commented Feb 11, 2019

Closes #13672, follow up from #13871. Discussed with @brunoabinader and agreed that this was the correct fix moving forward. We noticed that the easeTo values where wrapped but when you set a bounds that shouldn't be the case.

@tobrun tobrun added the Core The cross-platform C++ core, aka mbgl label Feb 11, 2019
@tobrun tobrun added this to the release-kombucha milestone Feb 11, 2019
@tobrun tobrun self-assigned this Feb 11, 2019
@julianrex
Copy link
Contributor

@captainbarbosa Can you check for effects on iOS please?

@LukasPaczos
Copy link
Member

Tested that it also resolves #13770.

@captainbarbosa
Copy link
Contributor

Tested on iOS with no observed issues 👍

@brunoabinader
Copy link
Member

Solved via #13958.

@brunoabinader brunoabinader deleted the tvn-bounds-check branch February 26, 2019 19:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Core The cross-platform C++ core, aka mbgl
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Map::setLatLngBounds crossing the IDL
5 participants