-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Android specific thread pool that keeps threads attached to JVM #14450
Conversation
60d4ea0
to
5d833b1
Compare
5d833b1
to
df9a998
Compare
Comment addressed. Just noting that I still need to make sure that https://circleci.com/gh/mapbox/mapbox-gl-native/264818 was not introduced by this PR. |
I've run CI jobs multiple times and couldn't catch the issue from #14450 (comment), neither could I reproduce locally. I think it's safe to say that it was a one-time occurrence, but I will monitor it further. Anyway, this is ready for another round. |
cde3f5f
to
3938e16
Compare
@LukasPaczos can we hold on this until we land #13935 ? |
Sure, what's the timeline for #13935 @tmpsantos? |
2 weeks |
6299e3c
to
4da712a
Compare
Thanks a lot for all the feedback! Since #13935 landed, I've changed the PR a little bit and it's ready for another round. |
a50c56a
to
49dd3eb
Compare
49dd3eb
to
bd28362
Compare
I've re-written to PR to follow @tmpsantos suggestion to use |
bd28362
to
09df5e7
Compare
09df5e7
to
f347606
Compare
b7b0724
to
74bf702
Compare
74bf702
to
06c267e
Compare
Closes #14048.
This PR adds a possibility to listen to thread's lifecycle within the thread pool and changes the Android's shared thread pool implementation to attach each of the threads in the pool to the JVM. This way, we are not constantly attaching/detaching JVM to those threads which was forcing GC runs.