This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Limit thread's scope to release the Object before detaching the thread #14757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasPaczos
added
Android
LukasPaczos
force-pushed
the
lp-snapshotter-tid-14747
branch
from
8e1e81b to
9aeec94
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14747.
Releases the thread's underlying
Objectbefore detaching the thread.I'm currently unable to include a regression test because when the
MapSnapshotteris run as part of the instrumentation test, the renderer doesn't return the snapshot and freezes. Test app examples work fine. This seems like a separate issue, it is the case even when checking out the code before #14450, investigating now./cc @tobrun