This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core] Failed sprite requests do not block tiles rendering #14605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Worth mentioning that this aligns the behavior with GL JS and we could have a render test for this. /cc @asheemmamoowala |
tmpsantos
approved these changes
May 7, 2019
kkaefer
reviewed
May 7, 2019
| @@ -309,6 +309,9 @@ void Style::Impl::onSpriteError(std::exception_ptr error) { | |||
| lastError = error; | |||
| Log::Error(Event::Style, "Failed to load sprite: %s", util::toString(error).c_str()); | |||
| observer->onResourceError(error); | |||
| // Unblock rendering tiles (even though sprite request has failed). | |||
| spriteLoaded = true; | |||
| observer->onUpdate(); | |||
There was a problem hiding this comment.
This will only unblock rendering in continuous mode. Still image mode will still fail because the onResourceError terminates the whole map render request.
Make sure that the `addOnStyleImageMissingListener` callback is invoked for missing images if sprite request has failed.
pozdnyakov
force-pushed
the
mikhail_render_tiles_with_missing_sprites
branch
from
8d04c3e
to
e008c93
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch unblocks tiles rendering if a sprite request has failed, it also enables
onStyleImageMissingAPI call for the missing image.Fixes #14582