[ios] Add changelog entry for Cache Management API #15131
Conversation
jmkiley
commented
Jul 16, 2019
•
jmkiley
commented
- Adds changelog entry for [ios] Cache Management API #14978
- Moves changelog entry pertaining to [ios] Exclude CJK resources from offline download by default. #14176
- Addresses setMaximumAmbientCacheSize megabytes or bytes? #15140 by fixing a typo.
platform/ios/CHANGELOG.md
Outdated
| @@ -8,6 +8,10 @@ Mapbox welcomes participation and contributions from everyone. Please read [CONT | |||
|
|
|||
| * Fixed a custom geometry source bug caused by using the outdated tiles after style update [#15112](https://github.com/mapbox/mapbox-gl-native/pull/15112) | |||
|
|
|||
| ### Offline maps | |||
There was a problem hiding this comment.
The Mobile Cache Management API affects more than just offline maps, because it allows for control over the ambient cache used in regular (non-offline) maps. Do the iOS release notes ever use "Features" as a heading? I think that would be the most appropriate heading.
There was a problem hiding this comment.
We don't use features as a heading, but I can move the entry to Other Changes. Features could be confusing, since we classify things based on what they do, rather than whether they are a feature or a bug fix.
platform/ios/CHANGELOG.md
Outdated
| @@ -8,6 +8,10 @@ Mapbox welcomes participation and contributions from everyone. Please read [CONT | |||
|
|
|||
| * Fixed a custom geometry source bug caused by using the outdated tiles after style update [#15112](https://github.com/mapbox/mapbox-gl-native/pull/15112) | |||
|
|
|||
| ### Offline maps | |||
|
|
|||
| * Added methods to invalidate and clear resources in the offline database. [#14978](https://github.com/mapbox/mapbox-gl-native/pull/14978) | |||
There was a problem hiding this comment.
I think this misses the method to resize the ambient cache, and also doesn't make it clear that the methods affect the ambient cache part of the database. Suggestion:
* Added methods to clear the ambient cache, change the size of the ambient cache, and delete and revalidate the database that contains the ambient and offline cache. These provide greater developer control over the impact of caching. [#14978](https://github.com/mapbox/mapbox-gl-native/pull/14978)
@tmpsantos @zugaldia @julianrex thoughts?
On second thought I should do this in a separate pr |
