Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[ios] Add changelog entry for Cache Management API #15131

Merged
merged 7 commits into from
Jul 17, 2019
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions platform/ios/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@ Mapbox welcomes participation and contributions from everyone. Please read [CONT

* Fixed a custom geometry source bug caused by using the outdated tiles after style update [#15112](https://github.com/mapbox/mapbox-gl-native/pull/15112)

### Offline maps
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Mobile Cache Management API affects more than just offline maps, because it allows for control over the ambient cache used in regular (non-offline) maps. Do the iOS release notes ever use "Features" as a heading? I think that would be the most appropriate heading.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't use features as a heading, but I can move the entry to Other Changes. Features could be confusing, since we classify things based on what they do, rather than whether they are a feature or a bug fix.


* Added methods to invalidate and clear resources in the offline database. [#14978](https://github.com/mapbox/mapbox-gl-native/pull/14978)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this misses the method to resize the ambient cache, and also doesn't make it clear that the methods affect the ambient cache part of the database. Suggestion:

* Added methods to clear the ambient cache, change the size of the ambient cache, and delete and revalidate the database that contains the ambient and offline cache. These provide greater developer control over the impact of caching. [#14978](https://github.com/mapbox/mapbox-gl-native/pull/14978)

@tmpsantos @zugaldia @julianrex thoughts?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great - very clear.


### Other changes
* Ideographic glyphs from Chinese, Japanese, and Korean are no longer downloaded by default as part of offline packs; they are instead rendered on-device, saving bandwidth and storage while improving performance. ([#14176](https://github.com/mapbox/mapbox-gl-native/pull/14176))

Expand Down