This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Calculate text collision correctly #1532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please review. |
|
@tmpsantos you might also want to have a look at @ansis's |
Also add a virtual setState() method to give subclasses a chance to intercept the change of state. This will be used by VectorTileData to release resources when the TileData becomes immutable.
We keep the Collision object alive longer because we need it for the SymbolBuckets yet to be created in case more data resources arrive. When the tile is no longer needed or if it is completely parsed or obsolete (i.e. in a immutable state) we throw the Collision object away.
In order to calculate the collision correctly, the layer ordering matters. Because of that, when we find the first incomplete symbol bucket, we stop processing any furter SymbolBucket. The side effect of this change is, if the first SymbolBucket is the last to receive its resources, we won't see any label at all on the screen until the last moment, when everything will be draw at once.
kkaefer
force-pushed
the
1465-text_collision
branch
from
4bc3843 to
3b92725
Compare
kkaefer
added a commit
that referenced
this pull request
May 13, 2015
Calculate text collision correctly
|
Next step is in #1539 |
kkaefer
added a commit
that referenced
this pull request
May 13, 2015
Calculate text collision correctly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1465.