This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Headless label placement tests aren't deterministic #1540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should be fixed by #1532, no? |
|
Nope, these images are with #1532 applied. |
|
For reference, this is where the tile boundaries are, it looks like the rendering errors are independent of the tile boundaries.
|
|
Narrowing down this test failure: It never happens when only one tile is being displayed, and it also doesn't happen when reducing the worker count to 1, so the error seems to be somewhere in concurrent tile parsing. |
kkaefer
referenced
this pull request
May 19, 2015
For now, the buckets depending on Glyphs that are not yet available are simply not created (or created and discarded). In the future we could refactor the code to not create the bucket at all or put the bucket in a suspended state until the glyph range is available.
|
What happened was that the Glyph PBF was marked as parsed before all of the glyphs were inserted into the FontStack. That means some labels (always at the beginning) were missing some letters because they couldn't be found when calculating the shaping. |
kkaefer
force-pushed
the
1540-disappearing-text
branch
from
6e15e30 to
bcf66b7
Compare
kkaefer
added a commit
to mapbox/mapbox-gl-test-suite
that referenced
this pull request
May 19, 2015
after fixing mapbox/mapbox-gl-native#1540
kkaefer
added a commit
to mapbox/mapbox-gl-test-suite
that referenced
this pull request
May 19, 2015
after fixing mapbox/mapbox-gl-native#1540
kkaefer
force-pushed
the
1540-disappearing-text
branch
from
a6c8546 to
d7bd429
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are few different renders of
text-color/default:/cc @ansis any idea how to debug this?