This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmalanen
force-pushed
the
jmalanen-ios-test
branch
19 times, most recently
from
February 5, 2020 17:21
c13d420
to
8c58883
Compare
jmalanen
force-pushed
the
jmalanen-ios-test
branch
11 times, most recently
from
February 10, 2020 13:08
981f1f9
to
1784540
Compare
zmiao
reviewed
Feb 12, 2020
jmalanen
force-pushed
the
jmalanen-ios-test
branch
3 times, most recently
from
February 13, 2020 13:28
47c85ed
to
314b2a2
Compare
zmiao
approved these changes
Feb 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
jmalanen
force-pushed
the
jmalanen-ios-test
branch
from
February 13, 2020 14:03
314b2a2
to
65aec17
Compare
alexshalamov
approved these changes
Feb 13, 2020
jmalanen
force-pushed
the
jmalanen-ios-test
branch
from
February 13, 2020 14:45
65aec17
to
6714442
Compare
The parameters were moved to iOS cmake file, so now the RenderTestApp can be built with cmake.
jmalanen
force-pushed
the
jmalanen-ios-test
branch
from
February 14, 2020 09:04
6714442
to
72f1945
Compare
This was referenced Feb 27, 2020
1ec5
reviewed
Feb 28, 2020
@@ -4,7 +4,7 @@ target_compile_definitions( | |||
) | |||
|
|||
if(NOT DEFINED IOS_DEPLOYMENT_TARGET) | |||
set(IOS_DEPLOYMENT_TARGET "9.0") | |||
set(IOS_DEPLOYMENT_TARGET "12.0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#16242 reverts this change.
This was referenced Mar 7, 2020
Merged
1ec5
reviewed
Mar 10, 2020
@@ -1,6 +1,26 @@ | |||
cmake_minimum_required(VERSION 3.10 FATAL_ERROR) | |||
project("Mapbox GL Native" LANGUAGES CXX C) | |||
|
|||
find_program(CCACHE_PROGRAM ccache) | |||
if(CCACHE_PROGRAM AND CMAKE_SYSTEM_NAME STREQUAL "iOS") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#16289 disables ccache on iOS.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also includes other improvements:
Fixes: mapbox/mapbox-gl-native-team#172