Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[test] iOS unit test runner #16158

Merged
merged 9 commits into from
Feb 14, 2020
Merged

[test] iOS unit test runner #16158

merged 9 commits into from
Feb 14, 2020

Conversation

jmalanen
Copy link
Contributor

@jmalanen jmalanen commented Jan 31, 2020

This PR also includes other improvements:

  • Share common code between test runners (render, unit and benchmark)
  • Enable ccache for iOS builds (reduces build times from 10 minutes to < 1 minute)
  • Fix the CPU core count for macOS builds
  • Change ios-xcode11-release build to use template and change the target arch from simulator to iPhone/arm64e
  • Bump minimum iOS version from 9.0 to 12.0

Fixes: mapbox/mapbox-gl-native-team#172

@jmalanen jmalanen force-pushed the jmalanen-ios-test branch 19 times, most recently from c13d420 to 8c58883 Compare February 5, 2020 17:21
@jmalanen jmalanen force-pushed the jmalanen-ios-test branch 11 times, most recently from 981f1f9 to 1784540 Compare February 10, 2020 13:08
@jmalanen jmalanen self-assigned this Feb 12, 2020
test/ios/ios_test_runner.cpp Outdated Show resolved Hide resolved
platform/ios/ios.cmake Outdated Show resolved Hide resolved
test/ios/Info.plist Show resolved Hide resolved
test/ios/ios_test_runner.cpp Outdated Show resolved Hide resolved
test/ios/iosTestRunner.mm Outdated Show resolved Hide resolved
test/ios/iosTestRunner.mm Show resolved Hide resolved
@jmalanen jmalanen force-pushed the jmalanen-ios-test branch 3 times, most recently from 47c85ed to 314b2a2 Compare February 13, 2020 13:28
Copy link
Contributor

@zmiao zmiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -4,7 +4,7 @@ target_compile_definitions(
)

if(NOT DEFINED IOS_DEPLOYMENT_TARGET)
set(IOS_DEPLOYMENT_TARGET "9.0")
set(IOS_DEPLOYMENT_TARGET "12.0")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#16242 reverts this change.

@@ -1,6 +1,26 @@
cmake_minimum_required(VERSION 3.10 FATAL_ERROR)
project("Mapbox GL Native" LANGUAGES CXX C)

find_program(CCACHE_PROGRAM ccache)
if(CCACHE_PROGRAM AND CMAKE_SYSTEM_NAME STREQUAL "iOS")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#16289 disables ccache on iOS.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants