Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

Mapbox GL Native v1.3.0 #181

Merged
merged 3 commits into from
Feb 29, 2020
Merged

Mapbox GL Native v1.3.0 #181

merged 3 commits into from
Feb 29, 2020

Conversation

1ec5
Copy link
Contributor

@1ec5 1ec5 commented Feb 27, 2020

Upgraded Mapbox GL Native from release-unicorn to v1.3.0:

Depends on mapbox/mapbox-gl-native#16242.

/cc @mapbox/maps-ios @mapbox/gl-native

@1ec5 1ec5 added this to the release-vanillashake milestone Feb 27, 2020
@1ec5 1ec5 requested a review from a team February 27, 2020 09:30
@1ec5 1ec5 self-assigned this Feb 27, 2020
@1ec5

This comment has been minimized.

@1ec5

This comment has been minimized.

@1ec5
Copy link
Contributor Author

1ec5 commented Feb 27, 2020

mapbox/mapbox-gl-native#16158 increased the minimum deployment target from iOS 9.0 to iOS 12.0. This makes it incompatible with the iOS map SDK, which still deploys backward to iOS 9.0. It isn’t particularly obvious, but the linker errors and warnings above are due to this minimum deployment target mismatch, because iOS 11 dropped the armv7 architecture.

@1ec5
Copy link
Contributor Author

1ec5 commented Feb 27, 2020

#140 attempted to port mapbox/mapbox-gl-native#16031, but it introduced an unused file and omitted the MGLMapView integrations on both iOS and macOS, so I manually re-ported those changes.

@1ec5
Copy link
Contributor Author

1ec5 commented Feb 28, 2020

mapbox/mapbox-gl-native#16158 increased the minimum deployment target from iOS 9.0 to iOS 12.0. This makes it incompatible with the iOS map SDK, which still deploys backward to iOS 9.0. It isn’t particularly obvious, but the linker errors and warnings above are due to this minimum deployment target mismatch, because iOS 11 dropped the armv7 architecture.

This PR is blocked on the fix in mapbox/mapbox-gl-native#16242, so we’ll have to upgrade to v1.2.1 rather than v1.2.0.

@1ec5 1ec5 removed the 🛑 blocked label Feb 28, 2020
@1ec5 1ec5 changed the title Mapbox GL Native v1.2.0 Mapbox GL Native v1.3.0 Feb 28, 2020
@1ec5
Copy link
Contributor Author

1ec5 commented Feb 28, 2020

I’ve upgraded to mapbox-gl-native v1.3.0 and made the changes required by mapbox/mapbox-gl-native#16238.

@1ec5

This comment has been minimized.

No one using the iOS or macOS map SDK will know whether it supports “global collision detection” based on “GL JS v0.42.0 or greater”.
@1ec5 1ec5 merged commit 87fac0b into master Feb 29, 2020
@1ec5 1ec5 deleted the 1ec5-gl-v1.2.0 branch February 29, 2020 19:13
@1ec5 1ec5 mentioned this pull request Mar 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants