Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[tile mode] Improvements in symbol placement on tile borders #16159

Merged
merged 1 commit into from
Feb 3, 2020

Conversation

pozdnyakov
Copy link
Contributor

This change fixes the following problems:

  1. Before this change, when multiple symbols were grouped close to the
    tile borders, different tiles could place different symbols, because each
    tile arbitrary assigned feature ids, and these ids defined the placement
    order being applied. This caused artifacts at the tile boundaries.
    With this change, in tile mode the placement order of two symbols crossing
    a tile border is defined by their anchor y values. It means that the
    symbols are being placed the same order across all the tiles.

  2. Before this change, the engine did not place with priority the symbols
    crossing the borders between two neighboring tiles. Now it does, and it
    improves a lot symbol placement stability in the tile map mode.

Fixes https://github.com/mapbox/mapbox-gl-native-team/issues/168

@pozdnyakov pozdnyakov added bug text rendering Core The cross-platform C++ core, aka mbgl needs changelog Indicates PR needs a changelog entry prior to merging. labels Jan 31, 2020
@pozdnyakov pozdnyakov self-assigned this Jan 31, 2020
@pozdnyakov pozdnyakov marked this pull request as ready for review January 31, 2020 13:56
Copy link
Contributor

@alexshalamov alexshalamov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

src/mbgl/text/placement.cpp Outdated Show resolved Hide resolved
src/mbgl/text/placement.cpp Show resolved Hide resolved
@pozdnyakov pozdnyakov force-pushed the mikhail_tile_mode_placement_fixes branch from ce3370f to a0d69b4 Compare February 3, 2020 18:26
This change fixes the following problems:
1) Before this change, when multiple symbols were grouped close to the
tile borders, different tiles could place different symbols, because each
tile arbitrary assigned feature ids, and these ids defined the placement
order being applied. This caused artifacts at the tile boundaries.

With this change, in tile mode the placement order of two symbols crossing
a tile border is defined by their anchor `y` values. It means that the
symbols are being placed the same order across all the tiles.

2) Before this change, the engine did not place with priority the symbols
crossing the borders between two neighboring tiles. Now it does, and it
improves a lot symbol placement stability in the tile map mode.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Core The cross-platform C++ core, aka mbgl needs changelog Indicates PR needs a changelog entry prior to merging. text rendering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants